Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing applications from single stages #50

Closed
hannesg opened this issue Dec 16, 2021 · 5 comments
Closed

Removing applications from single stages #50

hannesg opened this issue Dec 16, 2021 · 5 comments

Comments

@hannesg
Copy link
Member

hannesg commented Dec 16, 2021

As a developer, I want to remove an application from a single stage if it is not needed anymore.

Deploying an empty manifest currently doesn't work reliably. Also because we tell argocd to keep skip empty directories.

We should configure the argocd apps to actually work with empty manifests when the manifests are really empty.

@sven-urbanski-freiheit-com
Copy link
Contributor

Current workaround:
Instead of an empty manifest, define a configmap (or any kubernetes entity).

@sven-urbanski-freiheit-com
Copy link
Contributor

sven-urbanski-freiheit-com commented May 3, 2023

I think we need a button for this.
Deleting things in any automated way sounds dangerous.
Suggestion:

  • Add a button "Delete app from env"
  • When clicked, kuberpult deletes the files, and communicates to argo that we really want to delete them (AllowEmpty field).
  • the argoCd app should also be deleted

@sven-urbanski-freiheit-com
Copy link
Contributor

This is possible now via the API.
UI adaptation still need to be done https://revolution.dev/app/-JqFGExX46gs9mH7vxR5/-M37cZx7XYoOvQ5Mmcir/STORY/-NXAUHlQaHH1yrO9nk1P/

@sven-urbanski-freiheit-com
Copy link
Contributor

This is now implemented in the UI with the button "Remove Environment From App":
Screenshot from 2023-09-08 13-47-38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants