-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification and focus options #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Make sure the tests pass locally as well
tests also pass locally |
Co-authored-by: Federico Brigante <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking…
Actually the ugly field is due to Parcel: parcel-bundler/parcel#8866 |
I'm thinking about replacing the "Connected" notification with a non-removable overlay/UI: Thoughts? |
I don't like the non-removable part as your other solution is already working great for me
But I agree that for some users it might be better than right-clicking |
I suppose I can leave the right click and add the UI as a replacement of the connect notifications. This means you can still hide the UI and continue to use the right click.
That's a welcome change and it's easy to implement too. I think it only needs a manifest.json change and a onCommand listener in background.js PR welcome There's also a related request to remove the default one (it can still be set though) |
Done #269 |
Adds two options: