Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it secure to listen on *:4001 ? #306

Open
Un1Gfn opened this issue Jan 4, 2024 · 1 comment
Open

is it secure to listen on *:4001 ? #306

Un1Gfn opened this issue Jan 4, 2024 · 1 comment
Labels

Comments

@Un1Gfn
Copy link

Un1Gfn commented Jan 4, 2024

vscode 1.85.1 on macOS Sonoma 14.2.1

sudo lsof -i -P | grep -i listen

I get *:4001 instead of localhost:4001.

I think the default shall be listening on localhost only.

Probably offering an option in extension settings that allows changing the IP address on which it listens.

@fregante fregante added the vscode label Jan 4, 2024
@fregante
Copy link
Owner

fregante commented Jan 4, 2024

Good question. I don’t think that was intentional since I didn't specify which host to respond to:

https://github.com/fregante/GhostText-for-VSCode/blob/6f8f5f2fa96cb7f7287c4eda6fc56ba7d9960115/source/server.ts#L50

The Sublime Text version also doesn't specify the host, but its default behavior might be different:

https://github.com/GhostText/GhostText-for-SublimeText/blob/8ace809a1788ce99268cd585ac5c6635e84320f1/GhostText.py#L74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants