Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFG-1980 Promise error from new analytics endpoint #163

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

PFG-1980 Promise error from new analytics endpoint #163

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0d53df
PFG-1980
Barteezy Sep 20, 2023
9c1f1a2
PFG-1980 promise error update
Barteezy Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class GreedyPromise {
const continuation = () => {
let value = result[1];
let [handler, resolveFn] = result[0] === SUCCESS ? [onSuccess, resolve] : [onError, reject];
if (typeof handler === 'function') {
if (typeof handler === 'function' && value !== undefined && value !== null) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmmmmmm... well do we know why in our case on the first call this value could be undefined or null?

try {
value = handler(value);
} catch (e) {
Expand Down
Loading