Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements needs to be updated because of LXML changes #185

Open
flooie opened this issue Apr 19, 2024 · 1 comment
Open

Requirements needs to be updated because of LXML changes #185

flooie opened this issue Apr 19, 2024 · 1 comment

Comments

@flooie
Copy link
Collaborator

flooie commented Apr 19, 2024

doctor          |   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
doctor          |   File "/opt/app/doctor/urls.py", line 3, in <module>
doctor          |     from . import views
doctor          |   File "/opt/app/doctor/views.py", line 34, in <module>
doctor          |     from doctor.tasks import (
doctor          |   File "/opt/app/doctor/tasks.py", line 18, in <module>
doctor          |     from lxml.html.clean import Cleaner
doctor          |   File "/usr/local/lib/python3.10/site-packages/lxml/html/clean.py", line 18, in <module>
doctor          |     raise ImportError(
doctor          | ImportError: lxml.html.clean module is now a separate project lxml_html_clean.
doctor          | Install lxml[html_clean] or lxml_html_clean directly.

I'm updating doctor to better handle images or annotations inside a PDF but I came across our new friend - the removal of Cleaner functionality from lmxl.

We should remove and replace this code - I assume it's already causing issues that we haven't noticed yet or may soon enough.

@flooie flooie changed the title Cleaner Requirements needs to be updated because of LXML changes Apr 19, 2024
@mlissner
Copy link
Member

I don't think it should be causing issues, since we haven't updated any dependencies, but yeah, we should swap it out for NH3, like elsewhere. So it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants