-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to search filings by the things they cite #3454
Comments
This just needs analysis and possibly some schema work before we launch, but we don't need to build it until some time later. |
@mlissner I've analyzed the requirements of this feature and these are my findings and questions. According to how the We're going to add a new section: Cited by these documents: (RECAPDocuments)
When clicking the Here we will display all the RECAP documents that cite the opinion mentioned in the query: If this is correct, the only change needed in the ES RECAPDocument mapping (for child documents) is the inclusion of a new field
But you mentioned:
If we add just one or two new fields to the |
No. Document-level is fine.
Nah, seems complicated, we can skip it.
Correct.
Great!
No, I just meant that we'd need a re-index. Thank you. |
This is done and I even made a youtube video about it (on the FLP channel). |
@ss108 just added authority extraction for all of the filings in the RECAP Archive. This feature is really cool, but now we gotta build on it.
The next really cool thing we can and should do is allow filings to be searched by the things they cite. The way this will work, I think, is that we'll enhance the "Cited by" sidebar to have two sub-sections, probably separated by tabs. Here's how it looks now:
I think the trick will be to give it a section for opinions citing to the current one, and a section for filings citing the current one.
At the bottom of the current sidebar, we have a button that says "View Citing Opinions". When you click it, you are taken to the opinion search, where a basic search has been started for you, which you can refine however you choose.
We will need a similar button at the bottom of the filings section, except clicking it will take you to the RECAP Archive.
That'll take care of the UI part of this. Then, on the search side, we'll want to index the all the cited IDs in every filing, and make them searchable, like we do for opinions. This will require a new index, I believe, and a re-index from the DB of every item that cites another item, or maybe we can use the re-index API to use the old index, with a custom job to add the citation data to Elastic (it's only 22M rows, it'd be nice not to have to re-index all 400M for it!).
For now we need to know if a re-index is needed and maybe get these fields in place if so. Later, once Elastic is launched, we can do the rest of this, I think.
Open Questions
Do we load the filings sidebar section when the page loads even though they aren't visible until you switch to their tab or do we do it when somebody switches to their tab? The latter is better for performance of the page and of our server, the former is better for the user that clicks the tab (less waiting).
Do we have a button for citation alerts, so people can get a notification when a new filing cites something? It's a cool (and under-used) feature. But we'll need Add "Create an Alert" for RECAP searches #612 first.
Is this complicated enough that it should get something bigger and better than the sidebar? Maybe it's time to do a custom page for all this?
The text was updated successfully, but these errors were encountered: