-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid errors are reported in a CA-less IPA installation #201
Comments
This was raising a false positive in the IPA CA-less case. freeipa#201 Signed-off-by: Rob Crittenden <[email protected]>
The pki checks spew the error "Invalid PKI instance: pki-tomcat" so we need to suppress them in the IPA CA-less installation case. So if the IPA CA is not configured then don't register the pki sources. A side-effect is that to user the sources will not be listed at all in this case. This should not affect pki-healthcheck and it will continue to return errors in the unconfigured case. freeipa#201 Signed-off-by: Rob Crittenden <[email protected]>
The pki checks spew the error "Invalid PKI instance: pki-tomcat" so we need to suppress them in the IPA CA-less installation case. So if the IPA CA is not configured then don't register the pki sources. A side-effect is that to user the sources will not be listed at all in this case. This should not affect pki-healthcheck and it will continue to return errors in the unconfigured case. freeipa#201 Signed-off-by: Rob Crittenden <[email protected]>
This was raising a false positive in the IPA CA-less case. #201 Signed-off-by: Rob Crittenden <[email protected]>
The pki checks spew the error "Invalid PKI instance: pki-tomcat" so we need to suppress them in the IPA CA-less installation case. So if the IPA CA is not configured then don't register the pki sources. A side-effect is that to user the sources will not be listed at all in this case. This should not affect pki-healthcheck and it will continue to return errors in the unconfigured case. #201 Signed-off-by: Rob Crittenden <[email protected]>
Skipping the pki plugins was dependent upon the order the registry was being processed. The assumption was that the ipa plugin would be done first so ca_configured would be defined. If this isn't the case the the pki plugins are incorrectly skipped. So run through the list twice (it's short). Signed-off-by: Rob Crittenden <[email protected]> freeipa#201
python3-libsss_nss_idmap isn't required but if it is not present then the asumption is that trust is not available. This code was executing prior to collecting the ca_configured status so if the package was not installed then ca_configured could never be True. Signed-off-by: Rob Crittenden <[email protected]> freeipa#201
Skipping the pki plugins was dependent upon the order the registry was being processed. The assumption was that the ipa plugin would be done first so ca_configured would be defined. If this isn't the case the the pki plugins are incorrectly skipped. So run through the list twice (it's short). Signed-off-by: Rob Crittenden <[email protected]> #201
python3-libsss_nss_idmap isn't required but if it is not present then the asumption is that trust is not available. This code was executing prior to collecting the ca_configured status so if the package was not installed then ca_configured could never be True. Signed-off-by: Rob Crittenden <[email protected]> #201
I implemented ca_configured right originally, then ended up breaking it again. Other things can consume the core ipahealthcheck engine so I need to be careful not to impose too many IPA-isms into it. One of those consumers is dogtag which has its own pki-healthcheck. So this means we need to be able to run in these conditions:
Which basically equates to three states: True, False, None This was done originally with the ca_configured variable set to None. Using some inside knowledge the registries are loaded which will set ca_configured to True or False in the IPA registry. Using that we can determine if the pki checks should be available. Unfortunately I changed the initialization to False so it always assumes that IPA is installed. ca_configured will be False for the case of IPA not installed instead of None so we can't handle that last state. So I just need to flip it back to None and add a bunch of comments since this is not at all obvious. |
The pki healthchecks are noisy if a CA is not configured. We want to suppresse these in IPA so don't make the checks visible if a CA is not configured. So this means we need to be able to run in these conditions: 1. IPA is configured with a CA: the pki checks are run 2. IPA is configured without a CA: the pki checks are not run 3. IPA is not configured: the pki checks are run Which basically equates to three states: True, False, None This was done originally with the ca_configured variable set to None. Using some inside knowledge the registries are loaded which will set ca_configured to True or False in the IPA registry. Using that we can determine if the pki checks should be available. Unfortunately I changed the initialization to False so it always assumes that IPA is installed. ca_configured will be False for the case of IPA not installed instead of None so we can't handle that last state. So initialize ca_configured to False so we can satisfy all three states. freeipa#201 Signed-off-by: Rob Crittenden <[email protected]>
The pki healthchecks are noisy if a CA is not configured. We want to suppresse these in IPA so don't make the checks visible if a CA is not configured. So this means we need to be able to run in these conditions: 1. IPA is configured with a CA: the pki checks are run 2. IPA is configured without a CA: the pki checks are not run 3. IPA is not configured: the pki checks are run Which basically equates to three states: True, False, None This was done originally with the ca_configured variable set to None. Using some inside knowledge the registries are loaded which will set ca_configured to True or False in the IPA registry. Using that we can determine if the pki checks should be available. Unfortunately I changed the initialization to False so it always assumes that IPA is installed. ca_configured will be False for the case of IPA not installed instead of None so we can't handle that last state. So initialize ca_configured to None so we can satisfy all three states. freeipa#201 Signed-off-by: Rob Crittenden <[email protected]>
The pki healthchecks are noisy if a CA is not configured. We want to suppresse these in IPA so don't make the checks visible if a CA is not configured. So this means we need to be able to run in these conditions: 1. IPA is configured with a CA: the pki checks are run 2. IPA is configured without a CA: the pki checks are not run 3. IPA is not configured: the pki checks are run Which basically equates to three states: True, False, None This was done originally with the ca_configured variable set to None. Using some inside knowledge the registries are loaded which will set ca_configured to True or False in the IPA registry. Using that we can determine if the pki checks should be available. Unfortunately I changed the initialization to False so it always assumes that IPA is installed. ca_configured will be False for the case of IPA not installed instead of None so we can't handle that last state. So initialize ca_configured to None so we can satisfy all three states. freeipa#201 Signed-off-by: Rob Crittenden <[email protected]>
The pki healthchecks are noisy if a CA is not configured. We want to suppresse these in IPA so don't make the checks visible if a CA is not configured. So this means we need to be able to run in these conditions: 1. IPA is configured with a CA: the pki checks are run 2. IPA is configured without a CA: the pki checks are not run 3. IPA is not configured: the pki checks are run Which basically equates to three states: True, False, None This was done originally with the ca_configured variable set to None. Using some inside knowledge the registries are loaded which will set ca_configured to True or False in the IPA registry. Using that we can determine if the pki checks should be available. Unfortunately I changed the initialization to False so it always assumes that IPA is installed. ca_configured will be False for the case of IPA not installed instead of None so we can't handle that last state. So initialize ca_configured to None so we can satisfy all three states. #201 Signed-off-by: Rob Crittenden <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]> Reviewed-By: Rob Crittenden <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]>
Test if ipa-healthcheck complains about pki.server.healthcheck errors when CA is not configured on the replica. Related: freeipa/freeipa-healthcheck#201 Signed-off-by: Michal Polovka <[email protected]> Reviewed-By: Rob Crittenden <[email protected]>
This was raising a false positive in the IPA CA-less case. freeipa/freeipa-healthcheck#201 Signed-off-by: Rob Crittenden <[email protected]>
The pki checks spew the error "Invalid PKI instance: pki-tomcat" so we need to suppress them in the IPA CA-less installation case. So if the IPA CA is not configured then don't register the pki sources. A side-effect is that to user the sources will not be listed at all in this case. This should not affect pki-healthcheck and it will continue to return errors in the unconfigured case. freeipa/freeipa-healthcheck#201 Signed-off-by: Rob Crittenden <[email protected]>
Skipping the pki plugins was dependent upon the order the registry was being processed. The assumption was that the ipa plugin would be done first so ca_configured would be defined. If this isn't the case the the pki plugins are incorrectly skipped. So run through the list twice (it's short). Signed-off-by: Rob Crittenden <[email protected]> freeipa/freeipa-healthcheck#201
python3-libsss_nss_idmap isn't required but if it is not present then the asumption is that trust is not available. This code was executing prior to collecting the ca_configured status so if the package was not installed then ca_configured could never be True. Signed-off-by: Rob Crittenden <[email protected]> freeipa/freeipa-healthcheck#201
The pki healthchecks are noisy if a CA is not configured. We want to suppresse these in IPA so don't make the checks visible if a CA is not configured. So this means we need to be able to run in these conditions: 1. IPA is configured with a CA: the pki checks are run 2. IPA is configured without a CA: the pki checks are not run 3. IPA is not configured: the pki checks are run Which basically equates to three states: True, False, None This was done originally with the ca_configured variable set to None. Using some inside knowledge the registries are loaded which will set ca_configured to True or False in the IPA registry. Using that we can determine if the pki checks should be available. Unfortunately I changed the initialization to False so it always assumes that IPA is installed. ca_configured will be False for the case of IPA not installed instead of None so we can't handle that last state. So initialize ca_configured to None so we can satisfy all three states. freeipa/freeipa-healthcheck#201 Signed-off-by: Rob Crittenden <[email protected]>
Some invalid errors are reported by ipa-healthcheck in a CA-less installation.
This one by healthcheck itself:
And a bunch of these by the pki plugin. We may need to filter out this plugin if the CA is not configured.
The text was updated successfully, but these errors were encountered: