New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`new-password` route is defined twice #5434

Closed

eloquence opened this issue Aug 3, 2020 · 0 comments · Fixed by #5440

Labels

app

Member

eloquence commented Aug 3, 2020

It looks to me like this route in the admin UI is defined redundantly:
https://github.com/freedomofpress/securedrop/blob/develop/securedrop/journalist_app/admin.py#L219
https://github.com/freedomofpress/securedrop/blob/develop/securedrop/journalist_app/admin.py#L259

If there is no reason for this, we should remove one of the redundant definitions.

eloquence added the app label

eloquence added a commit that referenced this issue


          Remove duplicated route

23b5308

Resolves #5434

eloquence mentioned this issue

Remove duplicated route #5440

Merged

3 tasks

kushaldas closed this as completed in #5440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment