Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generation of screenshots is broken #7237

Closed
cfm opened this issue Sep 26, 2024 · 0 comments · Fixed by #7240
Closed

generation of screenshots is broken #7237

cfm opened this issue Sep 26, 2024 · 0 comments · Fixed by #7240
Labels
bug i18n Anything related to translation or internationalization of SecureDrop tests

Comments

@cfm
Copy link
Member

cfm commented Sep 26, 2024

Description

The procedure for taking fresh screenshots via make translation-test is currently broken.

Steps to Reproduce

$ LOCALES=en_US make translation-test

Expected Behavior

Screenshots are taken.

Actual Behavior

After #6954, LOCALES=en_US is invalid, because en_US is not listed in i18n.json. That's easy enough to fix (though this needs testing):

--- a/securedrop/i18n.json
+++ b/securedrop/i18n.json
@@ -20,6 +20,10 @@
       "name": "Greek",
       "desktop": "el"
     },
+    "en_US": {
+      "name": "English",
+      "desktop": "en_US"
+    },
     "es_ES": {
       "name": "Spanish",
       "desktop": "es_ES"

But then make translation-test fails with:

FAILED tests/functional/pageslayout/test_submit_and_retrieve_file.py::TestSubmitAndRetrieveFile::test_submit_and_retrieve_happy_path[en_US] - selenium.common.exceptions.InvalidSessionIdException: Message: WebDriver session does not exist, or is not active

Comments

Since this is the only place this path is exercised, I thought a compound ticket would be fine. I'll bring the fix in a compound pull request with separate commits.

@cfm cfm added bug tests i18n Anything related to translation or internationalization of SecureDrop labels Sep 26, 2024
@cfm cfm moved this to In Progress in SecureDrop dev cycle Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n Anything related to translation or internationalization of SecureDrop tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant