Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map_locale_display_names() does not set use_display_name for the first of multiple locales for a language #6475

Closed
cfm opened this issue Jun 3, 2022 · 0 comments · Fixed by #6485
Closed

map_locale_display_names() does not set use_display_name for the first of multiple locales for a language #6475

cfm opened this issue Jun 3, 2022 · 0 comments · Fixed by #6485
Assignees
@zenmonkeykstop
Labels
bug i18n Anything related to translation or internationalization of SecureDrop
Milestone
2.5.0

Comments

@cfm
Copy link
Member

cfm commented Jun 3, 2022

Description

For languages like pt and zh for which we now have multiple translated locales, map_locale_display_names() sets use_display_name for only the second and following locales. Prior to an overzealous refactoring in #6406, it would be set for all locales for a multi-locale language.

Steps to Reproduce

Reported by @deeplow in https://forum.securedrop.org/t/can-pt-br-become-portugues-brasil-instead-of-just-portugues/1455. Test cases TK.

Expected Behavior

  • pt_BR = Português (Brasil)
  • pt_PT = Português (Portugal)

Actual Behavior

  • pt_BR = Português
  • pt_PT = Português (Portugal)
@cfm cfm added bug i18n Anything related to translation or internationalization of SecureDrop labels Jun 3, 2022
@cfm cfm added this to the 2.5.0 milestone Jun 8, 2022
@zenmonkeykstop zenmonkeykstop self-assigned this Jul 11, 2022
@zenmonkeykstop zenmonkeykstop mentioned this issue Jul 11, 2022
Merged
4 tasks
@cfm cfm closed this as completed in #6485 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenmonkeykstop zenmonkeykstop

Labels
bug i18n Anything related to translation or internationalization of SecureDrop
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

fix: display full locale name for all locales with shared languages freedomofpress/securedrop
2 participants
@cfm @zenmonkeykstop