-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail gracefully if language no longer supported #6366
Comments
In yesterday's Server hangout, we affirmed interest in the following measures:
|
As of 635b856 my branch
(The "selected language" and "default language" cases come from the existing Next week once I'm back online: the remaining cases and tests, Git polishing, and the test plan and pull request. The latter will document (at least inline) the fine-grained distinctions introduced by this work in conjunction with #6156. |
Case (1)(3) is addressed as of 84ac53d, for which a pull request is incoming. Case (2) is already addressed by amnesia@amnesia:~/Persistent/securedrop$ ./securedrop-admin --force sdconfig
[...]
Space separated list of additional locales to support (tr cs zh_Hant en_US ru es
_ES de_DE pt_BR ro nb_NO fr_FR sk ca sv ar it_IT is hi zh_Hans el nl): es_ES de_
DE yy_ZZ
The following locales do not exist yy_ZZ amnesia@amnesia:~/Persistent/securedrop$ rm -rf securedrop/translations/de_DE
amnesia@amnesia:~/Persistent/securedrop$ ./securedrop-admin --force sdconfig
Space separated list of additional locales to support (ru en_US zh_Hant is hi ro
sk nb_NO ar el fr_FR zh_Hans sv nl ca pt_BR cs tr it_IT es_ES): es_ES de_DE
The following locales do not exist de_DE
My expectation is that this will happen automatically via |
In the course of development, a language may fall below an acceptable level of translation coverage, in which case we may want to remove it from the list of supported languages.
Currently, the app will fail (Source Interface will display an Internal Server Error) if an unsupported language is specified in
SUPPORTED_LOCALES
. This means that removing support for a language could break running instances.Safer behavior could be to ignore such locales (and fall back to English when specified as the default locale). An error could be displayed in
securedrop-admin
to the user next time they step throughsdconfig
, and an OSSEC email generated if an unsupported locale is detected in the configuration.The text was updated successfully, but these errors were encountered: