Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI: Re-Style Passphrase Widget #6213

Closed
2 tasks
ninavizz opened this issue Jan 5, 2022 · 1 comment
Closed
2 tasks

SI: Re-Style Passphrase Widget #6213

ninavizz opened this issue Jan 5, 2022 · 1 comment

Comments

@ninavizz
Copy link
Member

ninavizz commented Jan 5, 2022

This is a child-issue to the epic #6211

Problem

Today's "Passphrase Widget" is problematic for many reasons, summarized across many touchpoints & reports:

  • Lock semiotic confusing
  • Refresh functionality opportunity for user error
  • Colors outdated
  • A11y unfriendly hide/show control

Solution

New to Figma? So are all of us! Learn about SecureDrop on Figma.

  • Create new hide/show control per Figma
  • Implement re-designed passphrase widget that does the following:
  • Kill Remember your codename is: string
  • Kill padlock icon
  • Kill refresh control (Erik did already in PR Remove "Refresh codename" feature #6195)
  • Kill hide/show control placed inside widget itself.
  • Resize rectangular container
  • Place 28x28 weeble icon colored grimace blue. Mimic padding/positioning within Figma.
  • Container has 1px #FFFFFF outline & #FAFCFF fill
  • Give dropshadow per Figma
  • Place 7 irregularly wide #D0D3EB rectangles inside container for "Hidden" view. Rectangles imply redaction, do not need to dynamically resize to actual words. See Figma for sizing/padding/etc.
  • Connect new A11y friendly hide/show control
  • Typography: mmh... color grimace blue and make bold? May need to tweek size. Courier non-standard font, so probably want to stick with monospaced font.

Screen Shot 2022-01-04 at 6 55 00 PM

Screen Shot 2022-01-04 at 1 05 02 PM

oops... above screenshot grabbed, before `:focus` state added to hide/show control. 😸
@ninavizz ninavizz mentioned this issue Jan 5, 2022
42 tasks
@eaon
Copy link
Contributor

eaon commented May 2, 2022

Fixed in #6315

@eaon eaon closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants