-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt users to fix upgrade issue for Tails 4.14 - 4.18 (or fix it for them?) #6098
Comments
I'm more in favour of 2 (and also 1) than 3, just because altering the user's certs without their knowledge gives me the heebie-jeebies, but I'm not 100% against it. |
Yeah, that's very fair. Ok, maybe we can talk about it tomorrow and see what people think. The downside of 2 is that we'd need to settle on some translation strings pretty quickly. |
Per our discussion, here's an implementation of the third option. I've tested it on Tails 4.13 and 4.18. If this seems like roughly an approach we like, I'll submit a PR. |
A little more digging, a little more stress. My proposed method for validating the new cert was going to be to rely on the The other way we could do any kind of verification on the cert is to also download it from the LetsEncrypt website, and only install it if the versions from the tails website and the LE website match. Note: the Tails team does not include any kind of verification in their docs. Feedback welcome! |
If we can't (or don't want to) ignore the expiry time with something like the |
Description
Tails automatic upgrades were broken between versions 4.14 - 4.18 inclusive (Tails announcement), and some users on older versions of Tails may not realize that they are missing auto-updates, and that there is a manual step required to fix them.
We could:
I'm kind of in favour of the last option, and I can put in a PR for a check at the end of
securedrop_init
right before our GUI updater runs. What do others think? [edit: filing now so we can discuss inclusion in 2.1.0]The text was updated successfully, but these errors were encountered: