You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Honestly though, semantically, I think the first option makes more sense, but some have been using the second way. I understand this might be beyond the scope of this PR, but I feel this hacky solution should be changed soon.
Unfortunately I missed looking into this when I worked on #6315, but I looked at it now and just thought I'd note that I'm not convinced that :focus-within provides us with the functionality we want. Maybe I was to quick in going over this/testing stuff, but at least in the references @SaptakS shared, :focus-within would force users to tab through all the language links before they get to the main content. The checkbox solution requires an active interaction before language links even become available.
<details> and <summary> would allow us to do that too, but I also feel they're semantically distinct enough to make me prefer the checkbox solution.
That being said, how screen readers treat <details> and <summary> and whether this is a common pattern out there already would have an impact on my view here.
Originally posted by @SaptakS in #6041 (comment)
The text was updated successfully, but these errors were encountered: