Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

securedrop-admin integration tests fail during "tag is live, release is not" time window #5864

Open
eloquence opened this issue Mar 11, 2021 · 1 comment

Comments

@eloquence
Copy link
Member

eloquence commented Mar 11, 2021

Discovered during 1.8.0 release (#5794): If a tag has been pushed but the release object has not been created yet, two securedrop-admin tests start failing:

  • test_check_for_update_when_updates_not_needed
  • test_update_with_duplicate_branch_and_tag

Those tests operate against the production repo, and they rely on the latest release and the latest tag being identical. We should document this behavior in the RM guide, or make the tests more resilient. See #5862 (comment) for test output.

(We confirmed that this was indeed the cause by re-running CI after the release object was created.)

@eloquence eloquence mentioned this issue Mar 11, 2021
3 tasks
@eloquence eloquence added the docs label Mar 15, 2021
@eloquence
Copy link
Member Author

Discussed with @emkll at backlog review, we'll probably just document this behavior for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant