TBB detection not working in SI for TBB 10.0.4 on MacOS

[zenmonkeykstop]

Description

TBB 10.0.4 on MacOS is incorrectly identified as a non-Tor browser in the Source Interface

Steps to Reproduce

Start TBB 10.0.4 and visit an SI address.

Expected Behavior

• message displayed indicating that user should change security setting

Actual Behavior

• message displayed encouraging user to use Tor Browser "instead"

Comments

(Detection also failing on securedrop.org.)

[harrislapiroff]

I'll take a look at this for SDO purposes and share the necessary updates here

[harrislapiroff]

Looks like the issue is the bit of the user agent string to match the macOS version. The current string:

securedrop/securedrop/static/js/source.js

Line 1 in b16aa1f

const TBB_UA_REGEX = /Mozilla\/5\.0 \((Windows NT 10\.0|X11; Linux x86_64|Macintosh; Intel Mac OS X 10\.14|Windows NT 10\.0; Win64; x64); rv:[0-9]{2}\.0\) Gecko\/20100101 Firefox\/([0-9]{2})\.0/;

An updated string that works:

const TBB_UA_REGEX = /Mozilla\/5\.0 \((Windows NT 10\.0|X11; Linux x86_64|Macintosh; Intel Mac OS X 10\.[0-9]{2}|Windows NT 10\.0; Win64; x64|Android; Mobile); rv:[0-9]{2}\.0\) Gecko\/20100101 Firefox\/([0-9]{2})\.0/

(Note the specific bit that I changed was: Intel Mac OS X 10\.14} => Intel Mac OS X 10\.[0-9]{2}