Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build defenses against setuptools #5480

Closed
rmol opened this issue Sep 3, 2020 · 3 comments · Fixed by #5484
Closed

Build defenses against setuptools #5480

rmol opened this issue Sep 3, 2020 · 3 comments · Fixed by #5484

Comments

@rmol
Copy link
Contributor

rmol commented Sep 3, 2020

Description

We have been regularly derailed by setuptools breakage (#5212, #5150, #5471, etc.), despite several attempts to control its installation and usage in our packaging process. And it's just suboptimal to have no control over the versions of tools used to build our production packages (#5109). We should figure out once and for all how to pin it to a working version absolutely everywhere.

We made some progress with the alternative build system of dh-virtualenv in #5472, but it has serious bugs, and there are ongoing questions about how to include recent versions of dh-virtualenv in the Xenial container.

There are also some promising suggestions in #5109.

@conorsch
Copy link
Contributor

conorsch commented Sep 3, 2020

Note that the setuptools team has reverted the changes that led tot he breakage in #5471: pypa/setuptools#2376 Even so, the resilience we added in #5472 is well worth maintaining, simply to keep the build process on the rails over time.

@kushaldas
Copy link
Contributor

We once tried this already in #5110

@eloquence
Copy link
Member

@rmol and others will continue to investigate this during the 9/3-9/17 sprint. Options that have been explicitly suggested:

If these options don't work, we at least want to make sure we address the build behavior regression observed in #5472 (comment) e.g. via in-place substitution of the path name; though we've not identified any functional regression as a result of this path breakage, we don't want to ship from develop until this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants