You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Docker dev env currently displays the deprecation warning added in #5366:
Update Required: Your SecureDrop servers are still running v2 onion services ..
That means it's also in the generated screenshots. This may be fine for purposes such as Weblate (where it's useful to always see where a deprecation warning is shown), but it's not desirable for documentation, for user test environments, and for screenshot generation for other purposes. I suggest we add an environment variable to suppress the warning, or go the alternative route of turning it off by default.
The text was updated successfully, but these errors were encountered:
conorsch
changed the title
Suport disabling v2 deprecation warning in development environment
Support disabling v2 deprecation warning in development environment
Sep 3, 2020
@eloquence I will take a look into it. Is the desired behavior to introduce the environment variable and show warning accordingly, or to remove it altogether?
Thanks Prateek! :) I'd suggest turning it off by default and enabling it via environment variable, since all new installs will have v3. Please note that this is only for the Docker-based development environment, the behavior in staging/production should not change.
Since we'll likely replace the warning with a Focal EOL warning for 1.8.0 (#5688), this issue has outlived its usefulness. We can consider dev env behavior in the context of #5688.
The Docker dev env currently displays the deprecation warning added in #5366:
That means it's also in the generated screenshots. This may be fine for purposes such as Weblate (where it's useful to always see where a deprecation warning is shown), but it's not desirable for documentation, for user test environments, and for screenshot generation for other purposes. I suggest we add an environment variable to suppress the warning, or go the alternative route of turning it off by default.
The text was updated successfully, but these errors were encountered: