Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling v2 deprecation warning in development environment #5456

Closed
eloquence opened this issue Aug 17, 2020 · 4 comments
Closed

Support disabling v2 deprecation warning in development environment #5456

eloquence opened this issue Aug 17, 2020 · 4 comments

Comments

@eloquence
Copy link
Member

The Docker dev env currently displays the deprecation warning added in #5366:

Update Required: Your SecureDrop servers are still running v2 onion services ..

That means it's also in the generated screenshots. This may be fine for purposes such as Weblate (where it's useful to always see where a deprecation warning is shown), but it's not desirable for documentation, for user test environments, and for screenshot generation for other purposes. I suggest we add an environment variable to suppress the warning, or go the alternative route of turning it off by default.

@conorsch conorsch changed the title Suport disabling v2 deprecation warning in development environment Support disabling v2 deprecation warning in development environment Sep 3, 2020
@prateekj117
Copy link
Contributor

prateekj117 commented Sep 4, 2020

@eloquence I will take a look into it. Is the desired behavior to introduce the environment variable and show warning accordingly, or to remove it altogether?

@eloquence
Copy link
Member Author

Thanks Prateek! :) I'd suggest turning it off by default and enabling it via environment variable, since all new installs will have v3. Please note that this is only for the Docker-based development environment, the behavior in staging/production should not change.

@prateekj117
Copy link
Contributor

@eloquence Cool.

@eloquence
Copy link
Member Author

Since we'll likely replace the warning with a Focal EOL warning for 1.8.0 (#5688), this issue has outlived its usefulness. We can consider dev env behavior in the context of #5688.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants