Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update removed platform.linux_distribution funtion call in Python 3.8 #5433

Closed
kushaldas opened this issue Aug 3, 2020 · 3 comments · Fixed by #5559
Closed

Update removed platform.linux_distribution funtion call in Python 3.8 #5433

kushaldas opened this issue Aug 3, 2020 · 3 comments · Fixed by #5559
Assignees
@kushaldas
Labels
Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with

Comments

@kushaldas
Copy link
Contributor

Description

We are using platform.linux_distribution function in our metadata endpoint. But, this function was deprecated from Python3.5 and totally removed from Python 3.8.

Solution

We can directly read the /etc/lsb-release and /etc/os-release file as required.
@kushaldas kushaldas self-assigned this Aug 3, 2020
@kushaldas
Copy link
Contributor Author

#4768 is dependent on this.

@redshiftzero redshiftzero mentioned this issue Aug 3, 2020
Closed
53 tasks
@eloquence eloquence added Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with labels Sep 30, 2020
@DrGFreeman
Copy link
Contributor

@kushaldas and @eloquence, I can take care of this if it's OK with you.

@eloquence
Copy link
Member

That would be awesome, thanks @DrGFreeman :)

@DrGFreeman DrGFreeman mentioned this issue Oct 7, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kushaldas kushaldas

Labels
Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5433 replace platform.linux distribution DrGFreeman/securedrop
3 participants
@eloquence @kushaldas @DrGFreeman