Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pylint? #5306

Closed
redshiftzero opened this issue Jun 9, 2020 · 2 comments
Closed

remove pylint? #5306

redshiftzero opened this issue Jun 9, 2020 · 2 comments
Labels
needs/discussion queued up for discussion at future team meeting. Use judiciously. stale

Comments

@redshiftzero
Copy link
Contributor

Description

Do we getting anything additional from using pylint over flake8?

(Fwiw I got additional failures on #5298 on pylint compared to flake8)

@eloquence eloquence added the needs/discussion queued up for discussion at future team meeting. Use judiciously. label Jun 9, 2020
@redshiftzero
Copy link
Contributor Author

so I investigated this a bit because I was curious why I saw the behavior above - it turns out pylint does generally find more issues compared to pyflakes (what flake8 uses). What's happening is that pyflakes inspects the syntax tree of each source file separately, so it can't find issues across source files, e.g. like a call signature having the wrong number of arguments (i.e. if the function is imported from a different source file), but pylint can - albeit at the cost of speed.

Tbh given the above it might be worth actually using pylint more broadly in our repos in addition to flake8, so I'm gonna mark this one as pending close (not closing immediately to give others a chance to share thoughts)

@redshiftzero
Copy link
Contributor Author

closin'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/discussion queued up for discussion at future team meeting. Use judiciously. stale
Projects
None yet
Development

No branches or pull requests

2 participants