Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error when user attempts to generate codename in tab2 after logging out in tab1 #5249

Open
eloquence opened this issue May 12, 2020 · 1 comment

Comments

@eloquence
Copy link
Member

During QA for SecureDrop 1.3.0, @emkll reported the following session handling behavior:

There's an edge case, though not sure it's worth addressing:

  1. Click "Get Started" or hit /generate in both tabs A and B
  2. Click "Submit Documents" in tab A and logout
  3. Click "Submit Documents" in tab B, get immediately redirected to "You were logged out due to inactivity".

This behavior is new to 1.3.0, as prior to #5075, you would get an error on step 1.

For reference, the "Submit Documents" button is displayed on this screen:
Screen Shot 2020-05-11 at 17 14 46-fullpage

Questions:

  • Would it be preferable to let the user proceed to the submit screen? The downside is that it may result in the confusing generation of a second codename. On the other hand, that may be what the user wanted to do.
  • If we do bounce the user back to the index page, should we clarify the error message and explain what happened (something to the effect: you logged out in another tab, try logging in again with your codename?)
@eloquence
Copy link
Member Author

Tagged with security as this is a sensitive part of the source experience to make changes to. At the same time, as Mickael noted, this is an edge case, and IMO relatively low priority.

@eloquence eloquence changed the title Clarify error when user attempts to generate codename after logging out Clarify error when user attempts to generate codename in tab2 after logging out in tab1 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant