Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python errors in output from ./securedrop-admin restore #5029

Closed
zenmonkeykstop opened this issue Nov 25, 2019 · 5 comments
Closed

Python errors in output from ./securedrop-admin restore #5029

zenmonkeykstop opened this issue Nov 25, 2019 · 5 comments

Comments

@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented Nov 25, 2019

Description

Running in Tails 3.16, when the ./securedrop-admin restore command is run for the first time, the output includes the error messages below.

Steps to Reproduce

(Tails 3.16, fresh Prod VM or HW instance)

  • on the Admin Workstation back up the instance using ./securedrop-admin backup
  • restore the instance using ./securedrop-admin restore <backupFileName>

Expected Behavior

Command output includes no errors.

Actual Behavior

Command output looks like:

click to open
amnesia@amnesia:~/Persistent/securedrop$ ./securedrop-admin restore sd-backup-2019-11-25--20-14-51.tar.gz 
INFO: Restoring the SecureDrop Application Server from backup

PLAY [Restore SecureDrop Application Server from previous config.] *************************

TASK [Gathering Facts] *********************************************************************
ok: [app]

TASK [restore : Create temporary directory for Tor configuration check] ********************
changed: [app]

TASK [restore : Fetch current Tor configuration from app server] ***************************
changed: [app]

TASK [restore : Create directory to hold the Tor configuration from the backup] ************
changed: [app]

TASK [restore : Extract Tor configuration from backup] *************************************
changed: [app]

TASK [restore : Check for Tor configuration differences between the backup and server] *****
changed: [app]

TASK [restore : Remove temporary directory for Tor configuration check] ********************
changed: [app]

TASK [restore : Copy backup to application server] *****************************************
changed: [app]

TASK [restore : Extract backup] ************************************************************
changed: [app]

TASK [restore : Reconfigure securedrop-app-code] *******************************************
changed: [app]

TASK [restore : Reconfigure securedrop-config] *********************************************
changed: [app]

TASK [restore : Reload Apache service] *****************************************************
changed: [app]

TASK [restore : Reload Tor service] ********************************************************
changed: [app]

TASK [restore : Wait for Tor reload] *******************************************************
changed: [app]

PLAY RECAP *********************************************************************************
app                        : ok=14   changed=13   unreachable=0    failed=0   

Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7fa7ea4c7a60>
Traceback (most recent call last):
  File "/home/amnesia/Persistent/securedrop/admin/.venv3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable

Please provide screenshots where appropriate.

Comments

These errors don't appear to affect the restore script itself - the restore succeeds as far as I can tell. Subsequent restore commands do not display the errors.

@zenmonkeykstop zenmonkeykstop added this to the 1.2.0 milestone Nov 25, 2019
@zenmonkeykstop
Copy link
Contributor Author

Note that this is Tails 3.16 - if these errors were reported on a production system, first advice would be to upgrade to 4.0...

@redshiftzero
Copy link
Contributor

I confirm this is not happening on Tails 4

@conorsch
Copy link
Contributor

@eloquence eloquence removed this from the 1.2.0 milestone Nov 26, 2019
@eloquence
Copy link
Member

Should we close this, given that we no longer support the Tails 3 series?

@redshiftzero
Copy link
Contributor

yep lets close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants