securedrop-admin .venv not git ignored in 1.0.0

[emkll]

Description

After performing an install (with v3 onion URLs) on 1.0.0-rc2 branch, the .venv folder appears to be tracked by git:

amnesia@amnesia:~/Persistent/securedrop$ git status
HEAD detached at 1.0.0-rc2

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	.venv

I am not sure why

securedrop/.gitignore

Line 115 in ed53840

.venv*/

is not catching that folder.

Steps to Reproduce

• check out 1.0.0-rc2
• set v3_onion_urls = true in site-specific
• ./securedrop-admin install
• observe the output of git status as above

Expected Behavior

The venv should be git ignored, we don't want those changes to be tracked by git

Actual Behavior

.venv folder is tracked by git

Comments

The following diff resolves:

diff --git a/.gitignore b/.gitignore
index 1daefbeab..61cf92073 100644
--- a/.gitignore
+++ b/.gitignore
@@ -114,6 +114,7 @@ docs/_build/
 # virtualenv
 .venv*/
 venv/
+.venv/
 ENV/

[conorsch]

Following the test plan explicitly, I'm not able to get the .venv/ dir to show up. Note that the .venv/ dir shouldn't exist on an Admin Workstation—there's admin/.venv/, but .venv/ should be dev-ev only. Perhaps it's an artifact from repeated QA runs, @emkll?

Still, the changes presented in #4800 are clean, and a bit more explicit than what we had before, so I'm in favor of merging. Documenting inability to reproduce the issue as described above, in case others encounter it during QA.