Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test_admin_edits_hotp_secret is flaky #4580

Closed
eloquence opened this issue Jul 2, 2019 · 1 comment · Fixed by #4591
Closed

CI: test_admin_edits_hotp_secret is flaky #4580

eloquence opened this issue Jul 2, 2019 · 1 comment · Fixed by #4591
Assignees

Comments

@eloquence
Copy link
Member

Example flake: https://circleci.com/gh/freedomofpress/securedrop/30247

Relevant output:

_______________ TestAdminInterface.test_admin_edits_hotp_secret ________________

self = <tests.functional.test_admin_interface.TestAdminInterface object at 0x7fde8027d390>

    def test_admin_edits_hotp_secret(self):
        self._admin_logs_in()
        self._admin_visits_admin_interface()
        self._admin_adds_a_user()
        self._admin_visits_edit_user()
>       self._admin_visits_reset_2fa_hotp()

/home/circleci/project/securedrop/tests/functional/test_admin_interface.py:21: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/home/circleci/project/securedrop/tests/functional/journalist_navigation_steps.py:750: in _admin_visits_reset_2fa_hotp
    self.wait_for(lambda: self.driver.find_elements_by_css_selector(
/home/circleci/project/securedrop/tests/functional/functional_test.py:291: in wait_for
    return function_with_assertion()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    self.wait_for(lambda: self.driver.find_elements_by_css_selector(
>       "#button-reset-two-factor-hotp")[0])
E   IndexError: list index out of range

/home/circleci/project/securedrop/tests/functional/journalist_navigation_steps.py:751: IndexError
@redshiftzero
Copy link
Contributor

redshiftzero commented Jul 2, 2019

Assigning myself because I think the diff in fix-flake-4541 will also resolve this - I hit this when running test_admin_edits_hotp_secret in a loop and I added logic handling the IndexError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants