Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate/fix test flake: confirmation popup timeout in functional tests #4541

Closed
redshiftzero opened this issue Jun 19, 2019 · 1 comment · Fixed by #4546 or #4591
Closed

investigate/fix test flake: confirmation popup timeout in functional tests #4541

redshiftzero opened this issue Jun 19, 2019 · 1 comment · Fixed by #4546 or #4591
Assignees

Comments

@redshiftzero
Copy link
Contributor

Description

Test flake while waiting for a confirmation pop up in test_admin_adds_admin_user:

    def until(self, method, message=''):
        """Calls the method provided with the driver as an argument until the \
            return value is not False."""
        screen = None
        stacktrace = None
    
        end_time = time.time() + self._timeout
        while True:
            try:
                value = method(self._driver)
                if value:
                    return value
            except self._ignored_exceptions as exc:
                screen = getattr(exc, 'screen', None)
                stacktrace = getattr(exc, 'stacktrace', None)
            time.sleep(self._poll)
            if time.time() > end_time:
                break
>       raise TimeoutException(message, screen, stacktrace)
E       TimeoutException: Message: Timed out waiting for confirmation popup.

e.g. https://circleci.com/gh/freedomofpress/securedrop/29653

@redshiftzero
Copy link
Contributor Author

reopening for monitoring because @rmol reported seeing this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant