Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scenario fails on develop #4329

Closed
emkll opened this issue Apr 9, 2019 · 0 comments · Fixed by #4393
Closed

Upgrade scenario fails on develop #4329

emkll opened this issue Apr 9, 2019 · 0 comments · Fixed by #4393

Comments

@emkll
Copy link
Contributor

emkll commented Apr 9, 2019

Description

Running upgrade scenario on develop returns the following error:

    TASK [app-test : Install pip dependencies for running the unit and functional tests.] ***
    fatal: [app-staging]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'securedrop_code' is undefined\n\nThe error appears to have been in '/tmp/molecule/securedrop/upgrade/sd-orig/install_files/ansible-base/roles/app-test/tasks/dev_setup_xvfb_for_functional_tests.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Install pip dependencies for running the unit and functional tests.\n  ^ here\n"}
    
    NO MORE HOSTS LEFT *************************************************************
    
    NO MORE HOSTS LEFT *************************************************************
    
    PLAY RECAP *********************************************************************
    app-staging                : ok=4    changed=2    unreachable=0    failed=1   
    mon-staging                : ok=2    changed=1    unreachable=0    failed=0
    
    
ERROR: 
Makefile:175: recipe for target 'upgrade-test-local' failed

Steps to Reproduce

  1. git checkout develop
  2. make build-debs
  3. make upgrade-start
  4. make upgrade-test-local

Expected Behavior

Upgrade scenario should complete without error.

Actual Behavior

Upgrade scenario returns error (see above)

Comments

It appears that reverting 102afb5 resolves the issue for me locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants