Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs-only PRs from forks still run staging env in CI #3699

Closed
conorsch opened this issue Aug 6, 2018 · 0 comments · Fixed by #4158
Closed

Docs-only PRs from forks still run staging env in CI #3699

conorsch opened this issue Aug 6, 2018 · 0 comments · Fixed by #4158

Comments

@conorsch
Copy link
Contributor

conorsch commented Aug 6, 2018

Description

CI shouldn't run the staging tests when a PR is prefixed with docs-. At least in the case of PRs from forks, it seems to be doing so.

Steps to Reproduce

  1. Take a gander at added instructions on using libvirt Vagrant provider in Ubuntu & Debian #3670, and confirm the PR branch begins with docs-.
  2. Inspect the associated CI build for that PR and confirm it did in fact run the entire staging scenario.

Expected Behavior

CI does not run staging env when branch name for PR begins with docs-.

Actual Behavior

On at least one fork, CI did run the staging env, despite the fact that the branch name for the PR began with docs-.

Comments

It would be helpful to have a verbose wrapper script to make inspecting CI state easier. The script could print informative messages such as "Detected branch name 'docs-libvirt-setup', skipping staging run...".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant