Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate config.py for non-python format #3611

Open
heartsucker opened this issue Jun 29, 2018 · 0 comments
Open

Deprecate config.py for non-python format #3611

heartsucker opened this issue Jun 29, 2018 · 0 comments

Comments

@heartsucker
Copy link
Contributor

Description

(This may be a duplicate)

Reporting this here while documenting TODOs (#724).

From install_files/ansible-base/roles/app/tasks/initialize_securedrop_app.yml:

# config.py.example is already written using Jinja2 format, and should be
# easy to template-ize. However, we cannot do this because when Ansible writes
# a template, it re-does the entire thing. This would cause a problem in the
# case where we want to re-provision a machine with an updated value (e.g. the
# application key fingerprint). Blindly overwriting the entire file would cause
# major problems. It would be nice to use templates here, assuming we find a
# way to selectively update the file.

Noting that part of the issue here is that we can't read values out of Python formats (easily) which makes it hard to apply differential updates (which is why this was reported originally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant