Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests fail to add admins if requested #3608

Closed
heartsucker opened this issue Jun 29, 2018 · 3 comments
Closed

Functional tests fail to add admins if requested #3608

heartsucker opened this issue Jun 29, 2018 · 3 comments

Comments

@heartsucker
Copy link
Contributor

Description

Reporting this here while documenting TODOs (#724).

From securedrop/tests/functional/journalist_navigation_steps.py:

        if is_admin:
            # TODO implement (checkbox is unchecked by default)
            pass

Steps to Reproduce

Attempt to add an admin during functional tests.

Expected Behavior

An admin is added.

Actual Behavior

A regular use is added.

@eloquence
Copy link
Member

eloquence commented Sep 7, 2018

The current code is:

        if is_admin:
            raise NotImplementedError("Admin's can't be added yet.")

Problematic apostrophe usage aside, since it's now at least raising an error I'm removing the bug label.

@deepthinidwannaya
Copy link

I'm working on this. I've implemented the logic to select the checkbox and added a testcase for an admin creating an admin user and logging in with the newly created admin.

@heartsucker
Copy link
Contributor Author

Closed by #3854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants