Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.8.0] Custom Logo does not persist with upgrade #3528

Closed
emkll opened this issue Jun 14, 2018 · 2 comments
Closed

[0.8.0] Custom Logo does not persist with upgrade #3528

emkll opened this issue Jun 14, 2018 · 2 comments

Comments

@emkll
Copy link
Contributor

emkll commented Jun 14, 2018

Description

The optional custom logo that is on source and journalist interfaces is not preserved when the instance is upgraded from0.7.0 to 0.8.0. It is replaced with the default SecureDrop logo.

Steps to Reproduce

  1. Install SecureDrop 0.7.0 in prod vms
  2. Upload a custom Instance Logo
  3. Upgrade to SecureDrop 0.8.0~rc1
  4. Navigate to the Source interface and observe the default logo.

Expected Behavior

Upgrading to 0.8.0 should preserve the custom instance logo.

Actual Behavior

The custom logo is replaced by the default SecureDrop logo.

Comments

There are no apparmor/grsecurity errors, it seems like app code packaging/upgrade logic.
The custom logo is no longer found in /var/www/securedrop/static/i/

Workaround

Admin can run the install playbook to re-upload the image.

@emkll emkll added this to the 0.8 milestone Jun 14, 2018
@heartsucker
Copy link
Contributor

Related: #2807, #3057, #3219

@emkll
Copy link
Contributor Author

emkll commented Jun 15, 2018

This is due to an error on my part when building the debs: I had a local version of securedrop/static/i/custom_logo.png in the repo, which overrides the server version. Debs have been updated and I have confirmed the issue no longer persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants