Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functionality requiring libjpeg-dev #3375

Closed
redshiftzero opened this issue May 7, 2018 · 1 comment · Fixed by #3379
Closed

Remove functionality requiring libjpeg-dev #3375

redshiftzero opened this issue May 7, 2018 · 1 comment · Fixed by #3379
Assignees
@redshiftzero
Milestone
0.7

Comments

@redshiftzero
Copy link
Contributor

Description

Due to issue #3316, in order to ship current develop, we need to back out the functionality in #3057 that requires libjpeg-dev.

User Stories

As a SecureDrop administrator, I want my updates to occur without manual intervention.

As a SecureDrop maintainer, I do not want to make significant changes to auto updates right before a release.
@redshiftzero redshiftzero added this to the 0.7 milestone May 7, 2018
@redshiftzero redshiftzero self-assigned this May 7, 2018
@redshiftzero
Copy link
Contributor Author

OK the code part is in c950bfc - it backs out the minimum necessary for release. The high points are:

  • We have to change a string
  • We won't accept JPG/JPEG logos anymore
  • We can't resize as that needs Pillow which requires libjpeg-dev (there is a flag for compilation without libjpeg-dev but... it's a compile time flag so it's no good given our current deployment story)

Otherwise we can safely ship the other changes in #3057. The docs also need updating, will add tomorrow.

@redshiftzero redshiftzero mentioned this issue May 8, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

Back out functionality requiring libjpeg-dev apt dependency freedomofpress/securedrop
1 participant
@redshiftzero