Document -> Journalist interface renaming not gracefully handled by securedrop-admin script

[conorsch]

Bug

Description

We renamed the "Document Interface" to the "Journalist Interface" in #1395, and followed up with concerns related to migration and upgrades in #1614. Most of those seem to be resolved, but introduction of the securedrop-admin tooling, specifically the new Tails workstation configuration via Ansible (#1803), doesn't honor the old app-document-aths filename gracefully when running securedrop-admin tailsconfig. Screenshot of failure:

Steps to Reproduce

1. Check out the 0.3.12 tag.
2. Provision 0.3.12 prod VMs.
3. Boot Tails Admin Workstation.
4. Check out the release/0.4 branch.
5. Run ./securedrop-admin tailsconfig and it will fail.

Expected Behavior

Running the new scripts with a pre-0.4 config will work reasonably well, and not fail inscrutably due to files being renamed.

Actual Behavior

Running the new scripts with a pre-0.4 config fails inscrutably due to files being renamed.

Comments

We should be able to apply the following logic to handle the secrets on the Admin Workstation:

if [[ -e app-document-aths ]] ; then
    mv app-{document,journalist}-aths
done

The question, however, is where that migration logic best fits. It would be ideal to run it automatically, perhaps as a try/except block in the Tails config logic introduced in #1803.

[conorsch]

Resolved via #2000.