Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scanner integration] Handle redirection #522

Closed
harrislapiroff opened this issue Jul 11, 2018 · 2 comments
Closed

[scanner integration] Handle redirection #522

harrislapiroff opened this issue Jul 11, 2018 · 2 comments
Assignees

Comments

@harrislapiroff
Copy link
Contributor

In the process of investigating something unrelated I noticed that one of our directory entries has a landing page URL https://organization.tld/securedrop/ which redirects to https://securedrop.organization.tld. The landing page scanner should detect a redirect like this and behave accordingly.

This might actually be a sort of complicated problem, since presently we extract the domain from the landing page URL as a substring and ask pshtt to scan it as step 1 and then do an HTML scrape of the actual URL as step 2. We may need to reverse those steps in order to follow a redirect and scan the correct domain. (This will also stop us from using pshtt's bulk scan API, which probably doesn't actually give us a performance boost anyway, since it requires the same number of HTTP requests.)

@harrislapiroff harrislapiroff self-assigned this Jul 11, 2018
@harrislapiroff harrislapiroff changed the title Scanner should handle redirection [scanner integration] Handle redirection Jul 11, 2018
@eloquence
Copy link
Member

Looks like a duplicate of #494.

@harrislapiroff
Copy link
Contributor Author

Whoops, right you are. Though I have some questions, I'll add to that ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants