-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scanner integration] Add support for "moderate" and "severe" warnings on directory entry pages #514
Comments
Here's my proposed design for this: Hover should go all red, like so: For moderate warnings, basically the same design, but yellow. A couple questions for @eloquence and maybe @redshiftzero:
|
This looks great! Note that subdomains would get a moderate warning (#497) not a severe one per current spec, but I understand it's just an example. Both of the improvements you identify sound potentially worthwhile to me, but I would suggest focusing on the core functionality for now so we can get a version ready for preview by news organizations. During the significant wait time while we give them an opportunity to fix issues detected by the scanner, we can make some additional functional and cosmetic improvements. |
Part of epic #488. In some cases, depending on the results of a landing page scan, we want to show warnings on the directory entry pages (icons from #489):
Warning display logic
Any landing page scan may trigger a combination of 0..n moderate warnings, and 0..n severe warnings.
Regardless of the number of warnings, only a single icon should be shown (severe if any severe warnings are triggered, moderate if only moderate warnings are triggered). Next to the icon, the specific messages should be shown, such as "This SecureDrop landing page is hosted on a subdomain (etc.)."
Finally, at the end of the warning messages, a security recommendation should be shown. If a severe warning was triggered, the security recommendation should read:
If only moderate warnings were triggered, the security recommendation should read:
These messages should be displayed in close proximity to the landing page.
Whitelisting
In some cases, it will be necessary to suppress specific warnings. It may be useful to implement support for this in a generic fashion. The first case where we anticipate a need for this is the use of subdomains (#497), as it is sometimes innocuous.
Warning flag
The warnings should initially be off by default, and displayed through a per-request flag. See #489 for implementation details.
User stories
The text was updated successfully, but these errors were encountered: