Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for applying dom0 state in updater is broken #685

Closed
eloquence opened this issue Apr 7, 2021 · 0 comments · Fixed by #686
Closed

Error handling for applying dom0 state in updater is broken #685

eloquence opened this issue Apr 7, 2021 · 0 comments · Fixed by #686

Comments

@eloquence
Copy link
Member

STR

  1. Modify a script like /srv/salt/update-xfce-settings to exit 1 no matter what
  2. Run the updater manually

Expected result

Updater completes with error message

Actual result

Updater is suspiciously happy & launches app

Why

We're comparing against the enum type in https://github.com/freedomofpress/securedrop-workstation/blob/main/launcher/sdw_updater_gui/Updater.py#L307-L336 but are recording the status as an integer here:

securedrop-workstation/launcher/sdw_updater_gui/UpdaterApp.py

Line 190 in e182525

results["apply_dom0"] = result.value

We're correctly recording the status as an enum in the other assignments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@eloquence