-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clone-norpm target #655
Comments
For background, a long series of issues describing the reasons we migrated towards RPMs for the dev environment, described in #538 . It seems likely we are to repeat some of the errors from the past (e.g. RPM manifest issues), at the (increased) cost of maintaining two clone commands for the dev environment (and 4 distinct environments in all, which may be unnecessary). |
How long is cloning taking? For me, it's 4m the first time, and 5s after that:
The very first time a build is ever run, it'll likely be longer, to create the image. Depending on the freshness of the local (i.e. local to
|
To clarify, what motivated this change for me is that making small changes to |
In my own testing without any modifications, the first run took 3 minutes, while subsequent ones took <10 seconds. My vote would still be in favor of adding the target to give devs the option to reliably skip that performance hit when working on changes that don't require an RPM, but I defer to @emkll and am happy to close #656 if you don't think it's needed. |
If #656 is helpful to you @eloquence , given the size of the diff is fine to merge, we can always rename/remove if it becomes confusing. |
For working on
dom0
tests, it's helpful to skip the RPM build step when cloning the repo given how long it takes. To avoid writing the same local hacks over and over again, I suggest we add aclone-norpm
target or similar that does exactly that.The text was updated successfully, but these errors were encountered: