Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clean and sdw-admin --uninstall halt execution on error #545

Open
emkll opened this issue May 5, 2020 · 0 comments
Open

make clean and sdw-admin --uninstall halt execution on error #545

emkll opened this issue May 5, 2020 · 0 comments

Comments

@emkll
Copy link
Contributor

emkll commented May 5, 2020

When running the clean makefile target [1] (or the associated prod securedrop-admin target [2]), the operation will stop as soon as an error occurs. This means that the workstation is in a potentially unpredictable state, and some cleanup operations may not complete.

For example, in the case of functionality added #533, the custom tags are removed after vms are destroyed, if a Template is not destroyed due to an error ( for example TemplateVM used by an unmanaged AppVM), the tags will not be removed.

Since it is inherently destructive operation we should consider ignoring errors at runtime and continue execution, and report errors at the end

[1]

$(MAKE) destroy-all

[2]
def perform_uninstall():

@emkll emkll changed the title make clean and securedrop-admin uninstall will stop make clean and securedrop-admin uninstall halt execution on error May 5, 2020
@eloquence eloquence changed the title make clean and securedrop-admin uninstall halt execution on error make clean and sdw-admin uninstall halt execution on error Feb 9, 2021
@rocodes rocodes changed the title make clean and sdw-admin uninstall halt execution on error make clean and sdw-admin --uninstall halt execution on error Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants