Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clean does not work in staging or prod environments #483

Closed
emkll opened this issue Mar 3, 2020 · 0 comments · Fixed by #489
Closed

Make clean does not work in staging or prod environments #483

emkll opened this issue Mar 3, 2020 · 0 comments · Fixed by #489
Labels

Comments

@emkll
Copy link
Contributor

emkll commented Mar 3, 2020

Steps to reproduce, on a production install:

cd /usr/share/securedrop-workstation-dom0-config/
make clean

Due to changes in how files are provisioned with RPMs, we will need a staging/production specific clean makefile target. Removing the yum package will remove the provisioning logic, but will not delete files. The following commands in a makefile target work locally, we could also add this to securedrop-admin with a prompt/warning) but does not delete config files config.json and sd-journalist.sec (both in /usr/share/securedrop-workstation-dom0-config and /srv/salt/sd), which we could delete after uninstalling the dom0-config package).

  sudo qubesctl --show-output state.sls sd-clean-default-dispvm
  $(MAKE) destroy-all
  sudo qubesctl --show-output --skip-dom0 --targets whonix-gw-15 state.sls sd-clean-whonix
  sudo qubesctl --show-output state.sls sd-clean-all
  sudo dnf -y -q remove securedrop-workstation-dom0-config 2>/dev/null || true

This mostly impacts testing, as in production contexts, we should recommend properly disposing of (destroying) the storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants