Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apt upgrade logic requires dist-upgrade #273

Closed
conorsch opened this issue Jun 26, 2019 · 1 comment · Fixed by #276
Closed

Apt upgrade logic requires dist-upgrade #273

conorsch opened this issue Jun 26, 2019 · 1 comment · Fixed by #276

Comments

@conorsch
Copy link
Contributor

During a recent kernel version bump (freedomofpress/securedrop-builder#60), we observed that SDW VMs are not automatically receiving the new version:

The following packages have been kept back:
  securedrop-workstation-grsec
0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.

The problem appears to be lack of dist-upgrade in the upgrade logic

# Ensure all apt updates are applied, since the VMs
# will be cloned, duplicating package version drift.
update-all-apt-packages:
pkg.uptodate:
- cache_valid_time: "3600"
- require:
- pkg: install-python-apt-for-repo-config
. Let's at least add dist-upgrade and confirm upgrades are automatic. Worth considering using Qubes's qubes.update-vm state, but that's likely better handled as part of #51.

Also noting that the template build process uses a different location for the apt repo: https://github.com/freedomofpress/qubes-template-securedrop-workstation/blob/ce19add9e0dc817c7c83e6863b0ec66e34894b00/securedrop-workstation/04_install_qubes_post.sh#L45 Let's update the logic to reuse that same location, otherwise we'll have duplicate (and potentially conflicting) config files.

@emkll
Copy link
Contributor

emkll commented Jun 26, 2019

The securedrop-update daily cron does pass the dist-upgrade flag[0], so this should affect new installs only, up until the daily cron runs.

[0] : https://github.com/freedomofpress/securedrop-workstation/blob/master/dom0/securedrop-update#L50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants