Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install securedrop-proxy package in template for sd-journalist AppVM #161

Closed
redshiftzero opened this issue Oct 15, 2018 · 6 comments
Closed

Comments

@redshiftzero
Copy link
Contributor

redshiftzero commented Oct 15, 2018

The initial version of securedrop-proxy is here: https://apt-test-qubes.freedom.press/pool/main/s/securedrop-proxy/

We need to:

  1. Install this package in the template for sd-journalist (Related: renaming sd-journalist AppVM to sd-proxy (Convert sd-journalist to sd-proxy #138))
  2. Create config.yaml on disk in the sd-journalist AppVM, which contains e.g. the onion URL of the journalist interface
  3. Make Qubes RPC policy changes in dom0 needed for the proxy's operation as described here
@conorsch
Copy link
Contributor

As discussed during sprint planning today, these changes here should be additions to the sd-journalist config, not replacements. The goal is to preserve a working master branch on this repo, and until the client code is packaged and installed, we'll still need to use Tor Browser to download submissions for testing.

@conorsch
Copy link
Contributor

@redshiftzero Can you provide an example YAML configuration? I'm assuming the format is this: https://github.com/freedomofpress/securedrop-proxy/blob/9d040ce240fb837f34756c65e9f97c938a7c9e7f/config-example.yaml

What should target_vm be, for example?

@redshiftzero
Copy link
Contributor Author

the config should look like this where the string journalist_interface_url is replaced with whatever the onion service URL is (fetched from the config file in dom0):

host: journalist_interface_url
scheme: http
port: 80
target_vm: sd-svs
dev: False

@conorsch
Copy link
Contributor

Great, thanks, that's clear. Is there a specific filepath that the proxy app expects to find this file at? Reading the code in https://github.com/freedomofpress/securedrop-proxy/, it's not immediately obvious to me. Happy to shove it in /etc/securedrop/sd-proxy-config.yml, for instance, but want to make sure the app picks it up.

@redshiftzero
Copy link
Contributor Author

in the logic right now we have it at /etc/sd-proxy.yaml (ref)

@conorsch
Copy link
Contributor

Perfect, just what I needed! Get back to ya soon with a candidate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants