Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Add support for different device names #26

Closed
sssoleileraaa opened this issue Nov 8, 2019 · 3 comments · Fixed by #32
Closed

Add support for different device names #26

sssoleileraaa opened this issue Nov 8, 2019 · 3 comments · Fixed by #32
Assignees

Comments

@sssoleileraaa
Copy link
Contributor

Description

Add support for devices other than /dev/sda and /dev/sda1.

Right now, an export operation will fail if a user unplugs a device and plugs it back in before we luksClose, because it'll come back with a different name, like /dev/sdb.

@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Nov 21, 2019

more info

  • a device name of sda is not guaranteed if the device is yanked out during an export and reattached because it might be reattached as sdb if the export script was unable to properly luks-close and unmount the drive.

  • depending on the hardware some devices will show up as xvd* devices instead of sd* devices (see https://askubuntu.com/a/166087)

right now, the workaround is to attach the device commandline from dom0

@redshiftzero
Copy link
Contributor

@harlo had an interesting qubes observation which is that if you attach the USB via the CLI the device name is /dev/sd* and if you attach via the GUI it's /dev/xvd* (I checked and I see the same)

To @creviera's point, we should allow drives named both /dev/xvd* and /dev/sd* - we keep track of a list of possible device names, iterate through them, if we find one that works (i.e. is luks encrypted) we try to use it, if we find multiple then #25?

@sssoleileraaa
Copy link
Contributor Author

just a quick note....

until this issue is implemented, there are two workarounds (for people giving demos and developing export):

right now, the workaround is to attach the device commandline from dom0

if you want to use the guid, use the bottom menu (red) to attach your device instead of the top menu (blue)

device types

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants