Release securedrop-sdk 0.1.1 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://github.com/freedomofpress/securedrop-client/pull/1128/files, the requirements files were re-arranged, and the requirements.txt file could no longer be found. We check for the presence of a requirements file in requirements subfolder, after checking in the repo root, before erroring out.
4 tasks
kushaldas
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
- Ensure
sha256sums.txtsignature verifies and is signed with official securedrop release key - Ensure that hash of source tarball matches what is on PyPI: https://pypi.org/project/securedrop-sdk/0.1.1
- Ensure that hash of source tarball matches what is in the build logs: freedomofpress/build-logs@002fec2
- Ensure that hash of wheel matches what is in the build logs: freedomofpress/build-logs@002fec2
- Ensure that URLs are correct in the HTML part of the diff
- Review the changes to
build-sync-wheels
All good. Approved. 💯
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes freedomofpress/securedrop-sdk#127
build-sync-wheelsscript to support new requirements files location now used by securedrop-clientTest plan
sha256sums.txtsignature verifies and is signed with official securedrop release keybuild-sync-wheels