Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

securedrop-log build: add --ignore-installed and --no-deps #163

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

redshiftzero
Copy link
Contributor

Now that securedrop-log does have requirements, adding these two options that we are using for the other packages in this repository, see commit message for more details

Suggested test plan

  • Ensure that securedrop-log build passes in CI
  • Ensure that adding these options makes sense

`--ignore-installed` ensures that every dependency in
build-requirements.txt will be installed.

`--no-deps` provides a guard against "installing anything not
explicitly listed" [0]

[0] https://pip.readthedocs.io/en/stable/user_guide/#pinned-version-numbers
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🌈

@kushaldas kushaldas merged commit a755a3e into master Apr 13, 2020
@sssoleileraaa sssoleileraaa deleted the securedrop-log-pip-options branch September 13, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants