Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance for many submissions per source #984

Open
redshiftzero opened this issue Mar 24, 2020 · 4 comments
Open

improve performance for many submissions per source #984

redshiftzero opened this issue Mar 24, 2020 · 4 comments

Comments

@redshiftzero
Copy link
Contributor

On first start of the client, we add widgets for each item in the conversation view when we click on the source for the first time. If there are thousands of messages/files/replies per source, there will be a delay / the UI will be blocked as found with the SourceList in #846.

We should implement a similar fix as #944 to improve performance when adding widgets to the ConversationView.

@eloquence
Copy link
Member

For the 4/2-4/15 sprint, we'll aim to at least test in the "100 widgets per source" range, maybe with different combinations of messages/replies/documents. Would be good to have an agreed upon process for generating and using this dataset in a dev or staging env, per ongoing discussion in freedomofpress/securedrop#5186

@eloquence
Copy link
Member

Per #1049 (comment) the client seems to be responsive in scenarios of up to a thousand or so messages/replies/submissions. This may not be a useful target for further optimization unless/until we see evidence that even larger source collections plausibly occur in the real world.

@sssoleileraaa
Copy link
Contributor

started a wiki page to track scalability and performance requirements and test results (it'll need more attention when we make time for this in the future 🔮): https://github.com/freedomofpress/securedrop-client/wiki/Scalability-&-Performance

@zenmonkeykstop
Copy link
Contributor

Potentially related to #1476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants