Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending status begins showing after the deletion completes #951

Closed
redshiftzero opened this issue Mar 18, 2020 · 1 comment · Fixed by #955
Closed

pending status begins showing after the deletion completes #951

redshiftzero opened this issue Mar 18, 2020 · 1 comment · Fixed by #955
Labels

Comments

@redshiftzero
Copy link
Contributor

Right now source deletion on master does the following:

  1. User adds source deletion job to the queue.
  2. The job runs, and once we learn from the server that the deletion job was completed, the pending status is shown.
  3. We wait for a sync to run.
  4. The sync removes the source and its collection, removing the pending status.

This process nicely resolves #858. However, if a lot of network activity is happening, the pending status won't appear for a while, which means the user doesn't get feedback. I think the time to show the pending status is in step 1, when the source deletion job is added to the queue (similar to what we do for replies, where if a reply is queued to send to the server, it's in its pending state). Thoughts?

Cross-referencing #929

@eloquence eloquence added the ux label Mar 19, 2020
@eloquence
Copy link
Member

Yes, I was about to file the same issue. :) This would be great to clean up before launch because the current behavior feels a bit broken (though it appears to work just fine, so I won't add the bug label).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants