Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export/Print "Speedbump" screens experience polish #927

Closed
7 tasks
ninavizz opened this issue Mar 13, 2020 · 5 comments · Fixed by #940
Closed
7 tasks

Export/Print "Speedbump" screens experience polish #927

ninavizz opened this issue Mar 13, 2020 · 5 comments · Fixed by #940

Comments

@ninavizz
Copy link
Member

ninavizz commented Mar 13, 2020

Child issue w/in #910

This Issue's Punchlist

Zeplin, here
(note: this mockup uses screenshots w/ graphics added where things changed, so if you're confused why some text looks odd—well, that's why!)

  • Separate single screen into 2 distinct states: "Preparing" vs "Ready"
  • For Preparing
    • H1 text to say 'Preparing to [print or export]'
    • Spinner at top-left instead of device icon
    • 'Continue' button is disabled
  • For Ready
    • H1 text to say Ready to [print or export]
    • Show device icon in place of spinner at top-left of screen
    • Enabled "Continue" button

Etc

This issue is only for the functionality and two words of text, cited above. Any other inconsistencies between text between Zeplin and what's in the code, are not included in this issue.

@eloquence
Copy link
Member

eloquence commented Mar 13, 2020

@ntoll As discussed today this may be a bit hairy to test/develop without Qubes. It's not worth trying to get you up and running in Qubes in this final stretch of your contract -- but if you can make some headway on the above w/o Qubes, please have at it :).

@ninavizz
Copy link
Member Author

I can haz BIG spinner for Speedbump screen!
See Zeplin for sizing particulars. That's one of the only actual bits in that Zeplin, that's not part of a screenshot.

bigspinner

@ntoll
Copy link
Contributor

ntoll commented Mar 13, 2020

@ninavizz WRT the spinner... I've just noticed... but I believe it's not centred (i.e. it's not spinning around the centre) and thus wobbles. Gives me the heebie-jeebies in a motion-sickness sort of a way. 😝

The spinner in #912 looks / behaves well to me. I'll just use that. ;-)

@ninavizz
Copy link
Member Author

ninavizz commented Mar 13, 2020

@ntoll Thank you for catching that—reason(s) I shouldn't be delivering production assetts past my bedtime. ;)

The wobble is a Flash problem unique to how the art is configured, and quite frankly a BIG PITA when creating any circular spinner. Anywho, I've re-cut it with a hack to tone it down. When it's small as it will be in the Speedbump screen, the wobble isn't noticable. Hoping this one works for ya better—no queezies...

@ninavizz
Copy link
Member Author

Oopsie... this is it! As per the other one, I cut it 3x the size it should be in the client, so it shows-up as nice and crisp when at 100%. Again: there is a visible wobble when it's this big, but it's not visible when it's the size it should be in the Speedbump screen.

bigspinner-smh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants