Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not running new syncs if jobs from previous sync are still active #800

Open
eloquence opened this issue Feb 12, 2020 · 2 comments
Labels
needs discussion sync sync issues for future epic

Comments

@eloquence
Copy link
Member

We now kick off metadata syncs continuously, which is great. This also happens if we're still downloading replies/messages from a previous sync. This causes some additional complexity:

  • We'll need to account for it when updating the animation state (there are two separate desired animations, one for the metadata sync portion, and one for the downloading of messages/replies);
  • We'll need to account for it for changes to the status text like Add animation to sync area during message download #775, and potential future changes like message download counts.

I'd like to discuss whether we want to preserve this behavior, or if it might be better to defer a sync until all jobs associated with the previous sync are completed.

From a user's point of view, the behavior seems to have limited value, as the user is already waiting for new content to arrive.

I realize syncs also serve the function of monitoring network state, so whether or not changing the behavior is viable may depend in part on the final logic we want to use for monitoring the network state and pausing the queues.

@sssoleileraaa
Copy link
Contributor

this is somewhat a duplicate of #468

@eloquence
Copy link
Member Author

I agree the issues are closely related, if we implemented either of the ideas in #468, this would seem to give us a straightforward way to change the behavior as described here.

@zenmonkeykstop zenmonkeykstop added the sync sync issues for future epic label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion sync sync issues for future epic
Projects
None yet
Development

No branches or pull requests

3 participants