Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies aren't updating as successful once sent #766

Closed
redshiftzero opened this issue Feb 4, 2020 · 2 comments · Fixed by #772
Closed

Replies aren't updating as successful once sent #766

redshiftzero opened this issue Feb 4, 2020 · 2 comments · Fixed by #772
Labels
bug Something isn't working release blocker
Milestone
Initial beta release

Comments

@redshiftzero
Copy link
Contributor

STR

  1. send reply
  2. see it as pending

expected behavior

once reply sends successfully, reply updates to its confirmed (not grayed out/pending) state

actual behavior

reply does not update when successfully sent and stays in the pending state
@redshiftzero redshiftzero added the bug Something isn't working label Feb 4, 2020
@eloquence eloquence added this to the 0.2.0beta milestone Feb 4, 2020
@eloquence eloquence changed the title replies aren't updating as successful once sent Replies aren't updating as successful once sent Feb 4, 2020
@sssoleileraaa
Copy link
Contributor

looks like pending replies->failed replies works, but i also see pending replies->successful replies not working. i wonder if the reply_ready signal is no longer being emitted from the reply job handler

@redshiftzero
Copy link
Contributor Author

just discussed this one with @creviera and it turns out that this is a bug that was introduced due to the close merge of two PRs modifying related logic (and our no rebase/retest before final merge policy, which is primarily for dev agility): the snippets PR (#752) and my PR from yesterday (#764).

@sssoleileraaa sssoleileraaa mentioned this issue Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release blocker
Projects
None yet
Milestone
Initial beta release
Development

Successfully merging a pull request may close this issue.

update slots and signals to match freedomofpress/securedrop-client
3 participants
@eloquence @sssoleileraaa @redshiftzero