Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starring shouldn't result in entire source list update #760

Closed
sssoleileraaa opened this issue Feb 3, 2020 · 0 comments · Fixed by #952
Closed

Starring shouldn't result in entire source list update #760

sssoleileraaa opened this issue Feb 3, 2020 · 0 comments · Fixed by #952

Comments

@sssoleileraaa
Copy link
Contributor

Description

We currently update the entire source list in the GUI whenever a source is starred or unstarred. This is unnecessary since the star button is already toggled in the GUI.

Also, if the star job is unsuccessfully received by the server, is_starred will be updated to match what we have on the server on the next sync, which also updates the source list.

    def on_update(self, result):
        """
        The result is a uuid for the source and boolean flag for the new state
        of the star.
        """
        enabled = result[1]
        self.source.is_starred = enabled
        self.controller.update_sources()
        self.setChecked(enabled)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant