-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speech bubbles are appearing more than once in conversation view #734
Comments
Did you encounter it in Qubes or in a non-Qubes dev env only? |
I've only tested non-Qubes so far |
so - i've def seen this too, along with bubbles redrawn without their content, trying to get some STR (maybe related, maybe not) edit: hmm well I can't seem to reproduce either of these issues now... will wait until I see it again |
hard to verify due to no STR but i think this should be handled in #762 since any widgets that do not have corresponding items in the source collection will be deleted |
i also just saw another hard-to-repro issue related to this where a speech bubble is the wrong size and out of place: Also, it's hard to say, but I think this may have to do with the way we asynchronously update speech bubbles inline and call update_sources to update the entire source list on a successful sync. |
if anyone sees this again in the next few days please comment on this ticket, else we will close as resolved by #762 |
I've tried to recreate the problems described here, but fail. If anyone can provide STR I'll jump right on this, but my intuition is that the recent speech-bubble / inline conversation updates changes fix / mitigate this stuff happening again. |
thanks for investigating, I still haven't seen this either in recent days, so I'm gonna close this. |
Description
I haven't been able to successfully repro, but once while testing #688 I saw speech bubbles drawn multiple times in a conversation with some reordering:
#688 (review)
If anyone runs into this please provide details of your steps.
The text was updated successfully, but these errors were encountered: