Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech bubbles are appearing more than once in conversation view #734

Closed
sssoleileraaa opened this issue Jan 27, 2020 · 8 comments
Closed

Comments

@sssoleileraaa
Copy link
Contributor

Description

I haven't been able to successfully repro, but once while testing #688 I saw speech bubbles drawn multiple times in a conversation with some reordering:

#688 (review)

If anyone runs into this please provide details of your steps.

@sssoleileraaa sssoleileraaa added the bug Something isn't working label Jan 27, 2020
@eloquence
Copy link
Member

Did you encounter it in Qubes or in a non-Qubes dev env only?

@sssoleileraaa
Copy link
Contributor Author

I've only tested non-Qubes so far

@redshiftzero
Copy link
Contributor

redshiftzero commented Feb 3, 2020

so - i've def seen this too, along with bubbles redrawn without their content, trying to get some STR (maybe related, maybe not)

edit: hmm well I can't seem to reproduce either of these issues now... will wait until I see it again

@redshiftzero
Copy link
Contributor

hard to verify due to no STR but i think this should be handled in #762 since any widgets that do not have corresponding items in the source collection will be deleted

@sssoleileraaa
Copy link
Contributor Author

i also just saw another hard-to-repro issue related to this where a speech bubble is the wrong size and out of place:

Screenshot from 2020-02-03 19-19-28

Also, it's hard to say, but I think this may have to do with the way we asynchronously update speech bubbles inline and call update_sources to update the entire source list on a successful sync.

@redshiftzero
Copy link
Contributor

if anyone sees this again in the next few days please comment on this ticket, else we will close as resolved by #762

@ntoll
Copy link
Contributor

ntoll commented Feb 10, 2020

I've tried to recreate the problems described here, but fail. If anyone can provide STR I'll jump right on this, but my intuition is that the recent speech-bubble / inline conversation updates changes fix / mitigate this stuff happening again.

@redshiftzero
Copy link
Contributor

thanks for investigating, I still haven't seen this either in recent days, so I'm gonna close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants